-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:TalComUser Application form acknowledgment and redirection #1850
fix:TalComUser Application form acknowledgment and redirection #1850
Conversation
|
c6ce685
to
be2dabf
Compare
…chers/dev-launchers-platform into jeyanthi_sm/talComPageAck1470
<SignUpForm /> | ||
{/* <TalFormPage></TalFormPage> */} | ||
<SignUpForm handleCloseModal={handleCloseModal} /> | ||
{/* <TalCommForm></TalFormPage> */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this commented part required to keep?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was commented before and it was not part of this change.
@@ -157,13 +158,6 @@ export default function TalCommForm({ handleCloseModal, position }: Props) { | |||
onChange={handleSetCheckCheckbox} | |||
required | |||
/> | |||
<Checkbox | |||
label="I have read and agreed to the terms and conditions" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove this checkbox? I think it's nice to have it.
Applying without agreeing to the terms and conditions might become problematic down the line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the review, I added the Terms and Conditions checkbox and reverted the commented lines on the 'Second' page to their previous state.
…everted the commented lines on the 'Second' page to their previous state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you still don't use the new checkbox but I approve this PR while expecting that the new checkbox to be used in the future
TalComUser Applicant form acknowledgment and redirection