Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:TalComUser Application form acknowledgment and redirection #1850

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

jeyanthi-sm
Copy link
Contributor

TalComUser Applicant form acknowledgment and redirection

@jeyanthi-sm jeyanthi-sm requested a review from a team as a code owner July 1, 2024 15:54
Copy link

changeset-bot bot commented Jul 1, 2024

⚠️ No Changeset found

Latest commit: 78f6f99

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jeyanthi-sm jeyanthi-sm requested a review from a team as a code owner July 3, 2024 10:05
@jeyanthi-sm jeyanthi-sm force-pushed the jeyanthi_sm/talComPageAck1470 branch from c6ce685 to be2dabf Compare July 7, 2024 07:27
<SignUpForm />
{/* <TalFormPage></TalFormPage> */}
<SignUpForm handleCloseModal={handleCloseModal} />
{/* <TalCommForm></TalFormPage> */}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this commented part required to keep?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was commented before and it was not part of this change.

@@ -157,13 +158,6 @@ export default function TalCommForm({ handleCloseModal, position }: Props) {
onChange={handleSetCheckCheckbox}
required
/>
<Checkbox
label="I have read and agreed to the terms and conditions"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this checkbox? I think it's nice to have it.
Applying without agreeing to the terms and conditions might become problematic down the line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the review, I added the Terms and Conditions checkbox and reverted the commented lines on the 'Second' page to their previous state.

…everted the commented lines on the 'Second' page to their previous state.
Copy link
Member

@Enjoy2Live Enjoy2Live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you still don't use the new checkbox but I approve this PR while expecting that the new checkbox to be used in the future

@jeyanthi-sm jeyanthi-sm merged commit 05ac7d7 into development/recruitment Sep 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants