Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] User can call /user/id API and access other user data #179

Closed
becevka opened this issue Apr 28, 2024 · 6 comments
Closed

[Bug] User can call /user/id API and access other user data #179

becevka opened this issue Apr 28, 2024 · 6 comments
Assignees
Labels
bug Something isn't working Platform

Comments

@becevka
Copy link
Contributor

becevka commented Apr 28, 2024

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Login to strapi using '/api/auth/local' and test user with id 1, 'tester'
  2. Go to /api/users/2
  3. User details are returned with response code 200

Expected behavior
Response code 403 or other error not allowing to get another user details

ACCEPTANCE CRITERIA

  • PII is restricted to the currently authenticated user
  • The IdeaSpace workshopping page no longer displays PII (current displays users' emails)
  • The IdeaSpace comments no longer displays PII (currently displays users' full names)
@becevka becevka added the bug Something isn't working label Apr 28, 2024
@becevka
Copy link
Contributor Author

becevka commented Apr 28, 2024

Good read https://stackoverflow.com/questions/74728231/why-all-users-in-strapi-have-access-to-update-all-users-profile

@becevka
Copy link
Contributor Author

becevka commented Jun 23, 2024

  • We will need to enable this as we should be able to access profiles of users who posted comment, or created notifications.
  • The solution would be to add a middleware to select only configured fields in user and profile collection.

@dbradham
Copy link
Contributor

@chadcrotchett @chungthuang currently, user names and emails are displayed on the idea workshopping page. If this change is merged, IdeaSpace would need to update this page.

Chad, does it sound okay to you if we make a ticket in Platform board to use the display name instead of the emails or full legal names on the Idea Workshopping page? Or do you want this change to be made by the IdeaSpace team?

Image

Image

@chadcrotchett
Copy link

chadcrotchett commented Sep 21, 2024 via email

@dbradham
Copy link
Contributor

@chadcrotchett yes, we can remove PII from the Workshopping page.

  • Instead of displaying the user's full name on the comments, we will update to show their display name
  • Instead of displaying the user's email on the workshopping page, we will update to show their display name

@chadcrotchett
Copy link

chadcrotchett commented Sep 22, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Platform
Projects
None yet
Development

No branches or pull requests

5 participants