New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chef spec #43

Merged
merged 12 commits into from Oct 11, 2014

Conversation

Projects
None yet
2 participants
@bkw
Contributor

bkw commented Oct 11, 2014

coverage is at 100% and I spent some effort with the macs,kexs and ciphers, but no os specific testing yet.

@bkw

This comment has been minimized.

Show comment
Hide comment
@bkw

bkw Oct 11, 2014

Contributor

Sorry, I missed #39 ! Mea culpa!
Any reason why this wasn't merged?

Contributor

bkw commented Oct 11, 2014

Sorry, I missed #39 ! Mea culpa!
Any reason why this wasn't merged?

@bkw

This comment has been minimized.

Show comment
Hide comment
@bkw

bkw Oct 11, 2014

Contributor

Damn - some strange build failure on rub 1.9.3 since I switched to chef-server:
Have you seen this before?
https://travis-ci.org/TelekomLabs/chef-ssh-hardening/jobs/37696490

Contributor

bkw commented Oct 11, 2014

Damn - some strange build failure on rub 1.9.3 since I switched to chef-server:
Have you seen this before?
https://travis-ci.org/TelekomLabs/chef-ssh-hardening/jobs/37696490

@chris-rock chris-rock referenced this pull request Oct 11, 2014

Merged

Chef Spec Tests #39

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Oct 11, 2014

Member

hey @bkw thanks for providing the full coverage. We merged #39. Would it be possible to make this pr mergable on top of the latests changes?

Member

chris-rock commented Oct 11, 2014

hey @bkw thanks for providing the full coverage. We merged #39. Would it be possible to make this pr mergable on top of the latests changes?

@bkw

This comment has been minimized.

Show comment
Hide comment
@bkw

bkw Oct 11, 2014

Contributor

done.

Contributor

bkw commented Oct 11, 2014

done.

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Oct 11, 2014

Member

that is amazing. thanks @bkw 100% coverage! YEAH.

Member

chris-rock commented Oct 11, 2014

that is amazing. thanks @bkw 100% coverage! YEAH.

chris-rock added a commit that referenced this pull request Oct 11, 2014

@chris-rock chris-rock merged commit 4ea6830 into dev-sec:master Oct 11, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@bkw

This comment has been minimized.

Show comment
Hide comment
@bkw

bkw Oct 12, 2014

Contributor

that commit got messed up by rebasing. The file is fixed by the consecutive (rebased) commits, but this should not be cherry-picked or sth.

Contributor

bkw commented on f4f62dc Oct 12, 2014

that commit got messed up by rebasing. The file is fixed by the consecutive (rebased) commits, but this should not be cherry-picked or sth.

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Oct 12, 2014

Member

thanks for the notice

Member

chris-rock replied Oct 12, 2014

thanks for the notice

@bkw bkw deleted the bkw:addChefSpec branch Oct 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment