Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chef spec #43

Merged
merged 12 commits into from
Oct 11, 2014
Merged

Add chef spec #43

merged 12 commits into from
Oct 11, 2014

Conversation

bkw
Copy link
Contributor

@bkw bkw commented Oct 11, 2014

coverage is at 100% and I spent some effort with the macs,kexs and ciphers, but no os specific testing yet.

@bkw
Copy link
Contributor Author

bkw commented Oct 11, 2014

Sorry, I missed #39 ! Mea culpa!
Any reason why this wasn't merged?

@bkw
Copy link
Contributor Author

bkw commented Oct 11, 2014

Damn - some strange build failure on rub 1.9.3 since I switched to chef-server:
Have you seen this before?
https://travis-ci.org/TelekomLabs/chef-ssh-hardening/jobs/37696490

@chris-rock chris-rock mentioned this pull request Oct 11, 2014
@chris-rock
Copy link
Member

hey @bkw thanks for providing the full coverage. We merged #39. Would it be possible to make this pr mergable on top of the latests changes?

@bkw
Copy link
Contributor Author

bkw commented Oct 11, 2014

done.

@chris-rock
Copy link
Member

that is amazing. thanks @bkw 100% coverage! YEAH.

chris-rock added a commit that referenced this pull request Oct 11, 2014
@chris-rock chris-rock merged commit 4ea6830 into dev-sec:master Oct 11, 2014
@bkw bkw deleted the addChefSpec branch October 14, 2014 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants