use parse_config instead of parse_config_file #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
approved these changes
Aug 16, 2018
atomic111
approved these changes
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way the nginx-configuration is read.
Before, the indivual config-files got read.
Now the parsed nginx-configuration is read.
This way it does not matter where in the configuration an option is set.
As a next step I think we could (in a separate PR) remove the checks for
nginx_hardening = File.join(nginx_confd, '90.hardening.conf')and more generally check if the files in/etc/nginx/conf.dare secured against access. What do you think?CC @chris-rock @atomic111