Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix navbar dropdowns with long text #120

Merged
merged 1 commit into from
Oct 4, 2020
Merged

fix navbar dropdowns with long text #120

merged 1 commit into from
Oct 4, 2020

Conversation

ilesmana
Copy link
Contributor

@ilesmana ilesmana commented Oct 4, 2020

Description

Fixed: navbar dropdowns with long text cause the dropdown header to resize

Fixes #58 Bug: navbar dropdowns with long text cause the dropdown header to resize

Required checklist:

  • My code matches the existing code style of this project.
  • One of these:
    • This is a new localization for existing content.
    • This is new content that is localized for all the locales that this project currently supports.
    • I described above how I plan to localize this content immediately after merging these changes.
    • Localization is not applicable to this change.
  • I have tested my code and it successfully builds for GitHub Pages and validates as AMP.

@ilesmana ilesmana mentioned this pull request Oct 4, 2020
Closed
devadvance
devadvance approved these changes Oct 4, 2020
View reviewed changes
Copy link
Owner

@devadvance devadvance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Great work fixing this! Improved UX 👍

outputdemo

@devadvance devadvance merged commit 5f0a64f into devadvance:staging Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devadvance devadvance devadvance approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: navbar dropdowns with long text cause the dropdown header to resize
2 participants
@ilesmana @devadvance