Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hindi translation for the curl API rest guide #138

Merged
merged 5 commits into from
Oct 5, 2020

Conversation

IMPrimph
Copy link
Contributor

@IMPrimph IMPrimph commented Oct 5, 2020

Description

Please include a summary of this change and the issue(s) you are fixing. Include any context or information that will help a reviewer verify this PR quickly. List any caveats or issues with this change up front.

Fixes #66

Required checklist:

  • My code matches the existing code style of this project.
  • One of these:
    • This is a new localization for existing content.
    • This is new content that is localized for all the locales that this project currently supports.
    • I described above how I plan to localize this content immediately after merging these changes.
    • Localization is not applicable to this change.
  • I have tested my code and it successfully builds for GitHub Pages and validates as AMP.

Copy link
Owner

@devadvance devadvance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This translation is nearly complete! A few areas to improve before merging:

  • At the top of the file, the title and excerpt need a translation (replace the TODO).
  • The headings (lines beginning with ## should be translated where applicable.
  • Make sure you're not translating the commands or options (like -o) since those don't need to be translated.

i18n/hi/guides/curl-rest-api.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@IMPrimph IMPrimph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the changes specified

@IMPrimph
Copy link
Contributor Author

IMPrimph commented Oct 5, 2020

Done!
@devadvance

Copy link
Owner

@devadvance devadvance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for adding this valuable translation!

@devadvance devadvance merged commit 08a02bf into devadvance:staging Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Hindi translation of the curl REST API guide
2 participants