Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add french strings to translations.yml #76

Merged
merged 1 commit into from
Oct 3, 2020
Merged

Add french strings to translations.yml #76

merged 1 commit into from
Oct 3, 2020

Conversation

ttl41
Copy link
Contributor

@ttl41 ttl41 commented Oct 3, 2020 •
edited
Loading

Add french strings to translations.yml

Description

This adds a french translation to translations.yml

Fixes #63

Required checklist:

  • My code matches the existing code style of this project.
  • One of these:
    • My content is localized for all of the locales that this project currently supports.
    • I described above how I plan to localize this content immediately after merging these changes.
      • This is a translation
  • I have tested my code and it successfully builds for GitHub Pages and validates as AMP.

devadvance
devadvance approved these changes Oct 3, 2020
View reviewed changes
Copy link
Owner

@devadvance devadvance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for contributing!

@devadvance devadvance merged commit 47a184b into devadvance:staging Oct 3, 2020
@ttl41 ttl41 deleted the patch-2 branch October 3, 2020 08:48
devadvance pushed a commit that referenced this pull request Oct 3, 2020
@ttl41 @devadvance
Add french strings (#76)
b6d7da2
devadvance pushed a commit that referenced this pull request Oct 3, 2020
@ttl41 @devadvance
Add french strings (#76)
42b17e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devadvance devadvance devadvance approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add translations for general strings in French
2 participants
@ttl41 @devadvance