Load industries lists as static data #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudey
reviewed
Jul 2, 2020
| # do, as such we can hold them in memory for the entire duration the application | ||
| # is up. Saves us both network and garbage collection cost, at a small price. | ||
| # | ||
| # Proof available on request. |
There was a problem hiding this comment.
@yawboakye I'd like to request proof, for reference purposes. Will be a good reference point for similar decisions going forward.
Good changes, overall.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our list of industries don't change (they haven't changed in 2 years). But they're stored in a database table. Which means we incur network cost every time we render the register company page. This PR changes that. The data is now stored as YAML and loaded exactly once when the application starts. The loaded data is used for the entire duration of the app. It's a small memory cost, but definitely better than network + GC cost of the current implementation.