Skip to content

Conversation

nebula-it
Copy link
Contributor

No description provided.

@nebula-it nebula-it requested a review from a team as a code owner January 24, 2024 17:02
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time in contributing the changes.

I have left some comments and clarifying questions, thanks!

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for answering my questions, appreciate it. Left few more comments!

Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking for some test coverage, then we are all set.

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ⚡

Let's wait for test runs to turn 🟢 before we merge it!

@samruddhikhandale samruddhikhandale merged commit c04ead0 into devcontainers:main Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants