Skip to content

Conversation

brideo
Copy link
Collaborator

@brideo brideo commented Feb 28, 2023

No description provided.

@brideo brideo force-pushed the feature/AddTypeSenseAdapter branch from 0b2877c to a02a39c Compare February 28, 2023 10:35
@brideo brideo force-pushed the feature/AddTypeSenseAdapter branch from a02a39c to 7ad2495 Compare March 20, 2023 06:39
@brideo brideo force-pushed the feature/AddTypeSenseAdapter branch from b5a670b to d09643c Compare March 29, 2023 14:23
@brideo
Copy link
Collaborator Author

brideo commented Mar 30, 2023

image

image

I think all that is left to do is:

  1. Styling
  2. Testing that left nav filters work on category pages (for attributes)

Another note is on Click of the "Search" button in the header we get a javascript error, it's not breaking functionality but we should probably fix.

VM115313:7 Uncaught TypeError: Cannot read properties of null (reading 'focus')
    at eval (eval at <anonymous> (evaluator.js:81:20), <anonymous>:7:38)
    at nextTick.js:15:9
    at Oe (nextTick.js:24:40)
    at nextTick.js:9:7

I think we just need to add a #search ID to the input for the top search as Algolia doesn't and Hyva expects that.

$indexName,
$objects
){
die("here");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like debug code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants