Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix emit and EventHandler type annotations #47

Merged
merged 2 commits into from
Jun 8, 2017
Merged

Fix emit and EventHandler type annotations #47

merged 2 commits into from
Jun 8, 2017

Conversation

rvikmanis
Copy link
Contributor

#45

developit
developit approved these changes Apr 5, 2017
View reviewed changes
Copy link
Owner

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tunnckoCore
tunnckoCore approved these changes Apr 5, 2017
View reviewed changes
Copy link
Collaborator

@tunnckoCore tunnckoCore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rvikmanis
Copy link
Contributor Author

If you're all satisfied, can this be merged by someone with write access?

@developit developit merged commit 10711eb into developit:master Jun 8, 2017
@rvikmanis rvikmanis deleted the patch-1 branch June 8, 2017 13:20
@sebpearce sebpearce mentioned this pull request Jul 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit developit approved these changes

@tunnckoCore tunnckoCore tunnckoCore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rvikmanis @developit @tunnckoCore