Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edge case with rendering children as number 0 #18

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix edge case with rendering children as number 0 #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88278a1
fix edge case with rendering children as number 0
dburles Mar 18, 2019
015b1b9
don't attempt to render null children
dburles Mar 18, 2019
b3bd6bc
Merge branch 'master' into master
developit May 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vhtml.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export default function h(name, attrs) {
}
else while (stack.length) {
let child = stack.pop();
if (child) {
if (child !== undefined && child !== null) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would allow <div>{true}</div> to render <div>true</div>. Do we want that? The VDOM libs ignore booleans.

In any case, this statement can compress to:

Suggested change
if (child !== undefined && child !== null) {
if (child != null) {

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also allowed it before so we could leave as is or correct it, up to you. The shorter version while shorter is not explicit, it's better to always use the === and !== operators. Just my thoughts.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would concur with @dburles that being more explicit is often clearer. Also on the <div>{true}</div> debate mimicking the behaviour of React/Preact etc. seems intuitive.

if (child.pop) {
for (let i=child.length; i--; ) stack.push(child[i]);
}
Expand Down
30 changes: 28 additions & 2 deletions test/vhtml.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,34 @@ describe('vhtml', () => {
);
});

it('should support string fragments', () => {
it('should render a child of 0', () => {
function Child ({ children }) {
return <span>{children}</span>;
}
expect(
<div><Child>{0}</Child></div>
).to.equal(
'<div><span>0</span></div>'
);
});

it('should not attempt to render a child of null or undefined', () => {
function Child ({ children }) {
return <span>{children}</span>;
}
expect(
<div><Child>{null}</Child></div>
).to.equal(
'<div><span></span></div>'
);
expect(
<div><Child>{undefined}</Child></div>
).to.equal(
'<div><span></span></div>'
);
});

it('should support string fragments', () => {
expect(
h(null, null, "foo", "bar", "baz")
).to.equal(
Expand All @@ -189,5 +216,4 @@ describe('vhtml', () => {
'<p>foo</p><em>bar</em><div class="qqqqqq">baz</div>'
);
});

});