Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #40: Interpolated zero values are taken as false (zeros are not diplayed) #41

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes #40: Interpolated zero values are taken as false (zeros are not diplayed) #41

wants to merge 2 commits into from

Commits on Mar 25, 2023

  1. Update vhtml.js 

    Specifically check that child nodes are not strictly equal to `false` so that the value zero (0) gets rendered correctly.
    @aral
    aral committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    26f2e76 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. Update vhtml.js 

    Also add explicit checks for `undefined` and `null` (I’ve encountered `undefined` in my testing with [Kitten](https://codeberg.org/kitten/app). Haven’t hit `null` but it would also make it panic, so better safe than sorry). We could use a lax equality comparison (`==`) here but I prefer being explicit about it (but happy either way).
    @aral
    aral committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    0eb32c8 View commit details
    Browse the repository at this point in the history