Integrating segment-anything-services to ds-annotate #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 25, 2023 11:26
|
@Rub21 this is really exciting, and looks really good to me! But I don't know how to test it. How should we do this? Should we find a time to chat and maybe you can screenshare and go over the details? @willemarcel will you be able to help review this? This would be SO NICE to be able to see / demo. Thanks much for working on this @Rub21 ! |
|
@batpad , The app currently is sending the canvas and getting the return from SAM API. It is still missing to display the prediction on the map. |
added 17 commits
May 4, 2023 15:08
added 11 commits
June 22, 2023 16:22
rbavery
suggested changes
Jun 28, 2023
Co-authored-by: Ryan Avery <ryanbarryavery@gmail.com>
Co-authored-by: Ryan Avery <ryanbarryavery@gmail.com>
Co-authored-by: Ryan Avery <ryanbarryavery@gmail.com>
Co-authored-by: Ryan Avery <ryanbarryavery@gmail.com>
willemarcel
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
@Rub21 I think we can merge this and then work in 2 improvements
- Move the
Segment Anythingbutton to the sidebar and use a switch component instead, as it's just something to enable/disable a feature - Add a
Helplink in the sidebar that would open the instructions modal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc. @willemarcel @batpad