Add K_CE_OVERRIDE to cloudevents plugin. #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mneagul
reviewed
Sep 16, 2025
|
|
||
| # Apply KNative CE overrides if present | ||
| ce_extensions = {} | ||
| if k_ce_overrides := os.getenv("K_CE_OVERRIDES"): |
There was a problem hiding this comment.
Looking up K_CE_OVERRIDES in each call is not needed. It does not change over time.
pantierra
force-pushed
the
feature/add-k-ce-overrides
branch
from
e699382 to
08732c1
Compare
|
Indeed. Changed to read the overrides in at the beginning only. |
pantierra
force-pushed
the
feature/add-k-ce-overrides
branch
from
08732c1 to
f5ab594
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.