Use single lookup rather than lazy parameters #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I am changing
This PR moves the codebase away from the concept of lazy parameters. These lazy parameters were problematic in that 1) it causes an unnecessarily high number of requests to be made to SSM (one per unset parameter); 2) it causes issues when downstream tooling expects these values to be a string but instead they are this unique lazy parameter class.
How I did it
Utilize
get_parameters_by_path()to fetch all available parameters with a single API call.How you can test it
...
Related Issues
Closes #1