Parametrize test functions #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbusecke
commented
Sep 18, 2025
|
Seems like the cdk-checks failure is due to me submitting from a fork? |
hrodmn
approved these changes
Sep 18, 2025
Co-authored-by: Henry Rodman <henry.rodman@gmail.com>
|
Thanks for the suggestion! Just accepted it seems like all the unit tests are passing. |
jbusecke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was hacking away on integrating (virtual) icechunk support into titiler multidim I caught myself having to write a bunch of the same code for new datasets, which was error prone.
This PR wraps the store specific parameters into a dict and uses that as parametrized input for values and labels in the existing test functions.