Skip to content

Making RpcErrorModel nullable #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2024
Merged

Making RpcErrorModel nullable #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/src/model/rpc/rpc_error.model.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import 'rpc_error_data.model.dart';

class RPCError {
int code;
String message;
List<RPCErrorData> data;
int? code;
String? message;
List<RPCErrorData>? data;

RPCError({
required this.code,
Expand All @@ -12,8 +12,8 @@ class RPCError {
});

factory RPCError.fromJson(Map<String, dynamic> json) => RPCError(
code: json["code"],
message: json["message"],
code: json["code"] ?? 0,
message: json["message"] ?? "",
data: json["data"] != null
? List<RPCErrorData>.from(
json["data"].map((x) => RPCErrorData.fromJson(x)),
Expand All @@ -24,6 +24,6 @@ class RPCError {
Map<String, dynamic> toJson() => {
"code": code,
"message": message,
"data": List<dynamic>.from(data.map((x) => x.toJson())),
"data": List<dynamic>.from(data!.map((x) => x.toJson())),
};
}
12 changes: 4 additions & 8 deletions lib/src/model/rpc/rpc_error_data.model.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,15 @@




class RPCErrorData {
final int code;
final String message;
final int? code;
final String? message;

RPCErrorData({
required this.code,
required this.message,
});

factory RPCErrorData.fromJson(Map<String, dynamic> json) => RPCErrorData(
code: json["code"],
message: json["message"],
code: json["code"] ?? 0,
message: json["message"] ?? "",
);

Map<String, dynamic> toJson() => {
Expand Down
42 changes: 21 additions & 21 deletions test/nft_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ void main() {
owner: owner,
);
if (nfts.isLeft) {
fail(nfts.left.error.message);
fail(nfts.left.error.message!);
}
EnhancedNFTResponse resp = nfts.right;
var spamNfts = resp.ownedNfts.where((element) => element.spamInfo != null).where((element) {
Expand All @@ -51,7 +51,7 @@ void main() {
contractAddress: '0x000386e3f7559d9b6a2f5c46b4ad1a9587d59dc3',
);
if (result.isLeft) {
fail(result.left.error.message);
fail(result.left.error.message!);
}

print(result.right);
Expand All @@ -66,7 +66,7 @@ void main() {
orderBy: OrderBy.transferTime,
contractAddresses: ['0x000386e3f7559d9b6a2f5c46b4ad1a9587d59dc3']);
if (nfts.isLeft) {
fail(nfts.left.error.message);
fail(nfts.left.error.message!);
}

EnhancedNFTResponse resp = nfts.right;
Expand Down Expand Up @@ -99,7 +99,7 @@ void main() {
test('getOwnersForToken', () async {
var nfts = await api.getOwnersForToken(contractAddress: address, tokenId: token);
if (nfts.isLeft) {
fail(nfts.left.error.message);
fail(nfts.left.error.message!);
}
EnhancedNFTOwners resp = nfts.right;
expect(resp, isNotNull);
Expand All @@ -110,7 +110,7 @@ void main() {
test('getOwnersForCollection', () async {
var nfts = await api.getOwnersForCollection(contractAddress: address);
if (nfts.isLeft) {
fail(nfts.left.error.message);
fail(nfts.left.error.message!);
}
EnhancedNFTOwnerAddresses resp = nfts.right;
expect(resp, isNotNull);
Expand All @@ -122,7 +122,7 @@ void main() {
test('getOwnersForCollectionWithTokenBalances', () async {
var nfts = await api.getOwnersForCollection(contractAddress: address, withTokenBalances: true);
if (nfts.isLeft) {
fail(nfts.left.error.message);
fail(nfts.left.error.message!);
}
EnhancedNFTOwnerAddresses resp = nfts.right;
expect(resp, isNotNull);
Expand All @@ -139,7 +139,7 @@ void main() {
contractAddress: '0xe785E82358879F061BC3dcAC6f0444462D4b5330',
);
if (nfts.isLeft) {
fail(nfts.left.error.message);
fail(nfts.left.error.message!);
}
bool resp = nfts.right;
expect(resp, isNotNull);
Expand All @@ -152,7 +152,7 @@ void main() {
filters: [NFTSpamFilter.AIRDROPS, NFTSpamFilter.SPAM],
);
if (nfts.isLeft) {
fail(nfts.left.error.message);
fail(nfts.left.error.message!);
}
EnhancedNFTContracts resp = nfts.right;
expect(resp, isNotNull);
Expand All @@ -176,7 +176,7 @@ void main() {
refreshCache: false,
);
if (nfts.isLeft) {
fail(nfts.left.error.message);
fail(nfts.left.error.message!);
}
EnhancedNFT resp = nfts.right;
expect(resp, isNotNull);
Expand All @@ -193,7 +193,7 @@ void main() {
contractAddress: '0xe785E82358879F061BC3dcAC6f0444462D4b5330',
);
if (nfts.isLeft) {
fail(nfts.left.error.message);
fail(nfts.left.error.message!);
}
EnhancedNFTContractMetadata resp = nfts.right;
expect(resp, isNotNull);
Expand All @@ -208,7 +208,7 @@ void main() {
contractAddress: '0xe785E82358879F061BC3dcAC6f0444462D4b5330',
);
if (nfts.isLeft) {
fail(nfts.left.error.message);
fail(nfts.left.error.message!);
}
EnhancedNFTReingestContract resp = nfts.right;
expect(resp, isNotNull);
Expand All @@ -222,7 +222,7 @@ void main() {
query: 'sunglasses',
);
if (nfts.isLeft) {
fail(nfts.left.error.message);
fail(nfts.left.error.message!);
}
List resp = nfts.right;
expect(resp, isNotNull);
Expand All @@ -239,7 +239,7 @@ void main() {
withMetadata: false,
);
if (nfts.isLeft) {
fail(nfts.left.error.message);
fail(nfts.left.error.message!);
}
EnhancedNFTCollection resp = nfts.right;
expect(resp, isNotNull);
Expand All @@ -254,7 +254,7 @@ void main() {
withMetadata: true,
);
if (nfts.isLeft) {
fail(nfts.left.error.message);
fail(nfts.left.error.message!);
}
EnhancedNFTCollection resp = nfts.right;
expect(resp, isNotNull);
Expand Down Expand Up @@ -304,7 +304,7 @@ void main() {
test('getSpamContracts', () async {
var nfts = await api.getSpamContracts();
if (nfts.isLeft) {
fail(nfts.left.error.message);
fail(nfts.left.error.message!);
}
List resp = nfts.right;
expect(resp, isNotNull);
Expand All @@ -317,7 +317,7 @@ void main() {
contractAddress: '0xe785E82358879F061BC3dcAC6f0444462D4b5330',
);
if (nfts.isLeft) {
fail(nfts.left.error.message);
fail(nfts.left.error.message!);
}
bool resp = nfts.right;
expect(resp, isNotNull);
Expand All @@ -330,7 +330,7 @@ void main() {
tokenId: '44',
);
if (nfts.isLeft) {
fail(nfts.left.error.message);
fail(nfts.left.error.message!);
}
bool resp = nfts.right;
expect(resp, isNotNull);
Expand All @@ -342,7 +342,7 @@ void main() {
contractAddress: '0xe785E82358879F061BC3dcAC6f0444462D4b5330',
);
if (nfts.isLeft) {
fail(nfts.left.error.message);
fail(nfts.left.error.message!);
}
EnhancedNFTCollectionFloorPrice resp = nfts.right;
expect(resp, isNotNull);
Expand All @@ -361,7 +361,7 @@ void main() {
tokenId: '44',
);
if (nfts.isLeft) {
fail(nfts.left.error.message);
fail(nfts.left.error.message!);
}
NFTSalesResponse resp = nfts.right;
expect(resp, isNotNull);
Expand All @@ -377,7 +377,7 @@ void main() {
tokenId: '44',
);
if (nfts.isLeft) {
fail(nfts.left.error.message);
fail(nfts.left.error.message!);
}
List<NFTRarity> resp = nfts.right;
expect(resp, isNotNull);
Expand All @@ -392,7 +392,7 @@ void main() {
contractAddress: '0xe785E82358879F061BC3dcAC6f0444462D4b5330',
);
if (nfts.isLeft) {
fail(nfts.left.error.message);
fail(nfts.left.error.message!);
}
NFTAttributeSummary resp = nfts.right;
expect(resp, isNotNull);
Expand Down