Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slack notification step for nightly run failures #43

Merged
merged 11 commits into from
Jan 18, 2024

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Jan 15, 2024

What does this PR do?

This PR adds an extra step in the check_registry.yaml workflow. In case of failure, it sends a message in a specific slack channel using a secret SLACK_WEBHOOK_URL.

The format of the message has been defined inside the related issue.

Which issue(s) does this PR fix

fixes devfile/api#1255

PR acceptance criteria

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Unit/Functional tests

  • Documentation

How to test changes / Special notes to the reviewer

Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
@thepetk
Copy link
Contributor Author

thepetk commented Jan 15, 2024

WIP: As we should create two secrets for this alizer:

  1. SLACK_NOTIFICATIONS_TOKEN
  2. SLACK_CHANNEL_ID

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (80061c4) 73.16% compared to head (10fb309) 73.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   73.16%   73.16%           
=======================================
  Files          11       11           
  Lines        1565     1565           
=======================================
  Hits         1145     1145           
  Misses        351      351           
  Partials       69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
@thepetk thepetk changed the title WIP: Add slack notification step for nightly run failures Add slack notification step for nightly run failures Jan 17, 2024
@thepetk
Copy link
Contributor Author

thepetk commented Jan 17, 2024

WIP: As we should create two secrets for this alizer:

  1. SLACK_NOTIFICATIONS_TOKEN
  2. SLACK_CHANNEL_ID

/hold as the secrets will have to be created before merging the PR

Signed-off-by: thepetk <thepetk@gmail.com>
@thepetk
Copy link
Contributor Author

thepetk commented Jan 17, 2024

WIP: As we should create two secrets for this alizer:

  1. SLACK_NOTIFICATIONS_TOKEN
  2. SLACK_CHANNEL_ID

/hold as the secrets will have to be created before merging the PR

Both secrets are now created. Removing the WIP label.

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 17, 2024
Copy link

openshift-ci bot commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit dc7f5e9 into devfile:main Jan 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create notification on Product & Community Registries Check nightly run
2 participants