Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devfile library and odo version for registry tests #1367

Closed
1 task
thepetk opened this issue Dec 1, 2023 · 3 comments · Fixed by devfile/registry#265
Closed
1 task

Update devfile library and odo version for registry tests #1367

thepetk opened this issue Dec 1, 2023 · 3 comments · Fixed by devfile/registry#265
Assignees
Labels
area/ci area/registry Devfile registry for stacks and infrastructure

Comments

@thepetk
Copy link
Contributor

thepetk commented Dec 1, 2023

Which area/kind this issue is related to?

/area ci
/area registry

Issue Description

As seen in the checks of this PR when someone tries to add multiple endpoints, from different components, sharing the same port the validate_devfile_schemas & check_odov3 tests are failing.

For validate_devfile_schemas the reason is that we are using an old version of the devfile library for this test. In its latest version the library allows a devfile to have same ports for different component endpoints.

For check_odov3 we should wait until a new version is released, as odo very recently updated their library version. This way we should be able to pass the check_odov3 check having same ports for different component endpoints.

Acceptance Criteria

  • The library version is updated inside tests/validate_devfile_schemas/go.mod to a version that supports having same port numbers for different components.
@openshift-ci openshift-ci bot added area/ci area/registry Devfile registry for stacks and infrastructure labels Dec 1, 2023
@thepetk thepetk added the severity/blocker Issues that prevent developers from working label Dec 1, 2023
@thepetk
Copy link
Contributor Author

thepetk commented Dec 1, 2023

blocking #998

@thepetk
Copy link
Contributor Author

thepetk commented Jan 5, 2024

Putting back in review as we need to check how the odo version update will be handled

@thepetk thepetk removed the severity/blocker Issues that prevent developers from working label Jan 8, 2024
@thepetk
Copy link
Contributor Author

thepetk commented Jan 8, 2024

I've created #1415 in order to investigate the usage of odo nightly builds in registry tests. As the new issue will take care of odo update, we can close the current issue.

@thepetk thepetk closed this as completed Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci area/registry Devfile registry for stacks and infrastructure
Projects
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

1 participant