-
Notifications
You must be signed in to change notification settings - Fork 74
Description
Which area this feature is related to?
/area landing-page
Which functionality do you think we should add?
Why is this needed? Is your feature request related to a problem?
https://github.com/devfile/devfile.github.io currently holds the https://github.com/devfile/docs github pages for site devfile.github.io, we will need to also host the landing pages from https://github.com/devfile/landing-page
Detailed description:
Describe the solution you'd like
Currently, https://github.com/devfile/devfile.github.io holds the github pages for devfile.github.io since we get only one github page domain for a github orgranization. This repo currently holds the built pages from the docs https://github.com/devfile/docs
But we would like devfile.github.io to land on the landing pages from https://github.com/devfile/landing-page. So https://github.com/devfile/devfile.github.io would host both the landing-pages and docs repositories built pages.
There is a POC on @braden-wilson's personal repo:
site https://braden-wilson.github.io/docs/ (equivalent to devfile.github.io)
repo https://github.com/braden-wilson/docs/tree/gh-pages (equivalent to https://github.com/devfile/devfile.github.io)
There are a few steps to complete these.
- On a main branch push workflow, https://github.com/devfile/docs should sent a dispatch to the landing-page repo https://github.com/devfile/landing-page to trigger a build on the landing-page repo workflow
- The landing-page repo workflow would need to fetch the docs repo and build its pages along with the landing-page pages to deploy (similar to POC https://github.com/braden-wilson/docs/tree/gh-pages)
- CNAME https://github.com/devfile/devfile.github.io/blob/master/CNAME would need to be removed since we no longer want devfile.github.io to redirect to docs.devfile.io
- devfile.io DNS needs to be updated for the
docs
entry from docs.devfile.io to the appropriate link (docs link like the POC https://braden-wilson.github.io/docs/site) - devfile.io redirector config map would need to be updated from docs.devfile.io (to perhaps devfile.github.io?)
- Update expected return codes for blackbox probes
- 3xx codes for docs.devfile.io to devfile.io/docs
- 2xx codes for devfile.io
Describe alternatives you've considered
N/A since for the devfile org https://github.com/devfile, we only get one github page domain devfile.github.io