Create empty .npmignore file so that everything in the typescript models are published #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
are published. Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
JPinkney
requested review from
amisevsk,
davidfestal and
sleshchenko
as code owners
benoitf
approved these changes
Mar 29, 2021
sleshchenko
approved these changes
Mar 29, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: benoitf, JPinkney, sleshchenko The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Josh Pinkney joshpinkney@gmail.com
What does this PR do?
This PR creates an empty .npmignore file so that nothing is ignored when creating the npm package. Apparently if an .npmignore file isn't available then .gitignore is used and that's why some of the dist files are missing
What issues does this PR fix or reference?
Is your PR tested? Consider putting some instruction how to test your changes
Docs PR