Skip to content

Conversation

sleshchenko
Copy link
Member

What does this PR do?:

Append v to devfile type version to avoid model word appearing.

Which issue(s) this PR fixes:

No issue is created

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer:

I've tested so, currently, we have types like model220Devfile, model220DevfileMetadataComponent.
With my changes they will be v220Devfile and v220DevfileMetadataComponent.
So, it's a bit nicer but I don't have a strong opinion

@openshift-ci
Copy link

openshift-ci bot commented Jul 21, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JPinkney, sleshchenko

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sleshchenko sleshchenko merged commit ff76520 into main Jul 21, 2021
@sleshchenko sleshchenko deleted the improveDevfileTypes branch July 21, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants