Fix generating arrays for top level properties #558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleshchenko
changed the title
sleshchenko
force-pushed
the
typescriptModel
branch
from
0ba5a5c to
26cfd1a
Compare
sleshchenko
force-pushed
the
fixRootLevelArray
branch
from
5ea54be to
16aabb3
Compare
sleshchenko
force-pushed
the
fixRootLevelArray
branch
from
16aabb3 to
782be7b
Compare
JPinkney
approved these changes
Jul 22, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JPinkney, sleshchenko The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
this PR fixes generating arrays for top level properties, like devfile.projects, devfile.commands.
Which issue(s) this PR fixes:
fixes #557
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
How to test changes / Special notes to the reviewer:
run ./build/typescript-model/generate.sh and that
V220Devfilehas array for projects, commands and so on.