Skip to content

Conversation

JPinkney
Copy link
Contributor

Signed-off-by: Josh Pinkney joshpinkney@gmail.com

What does this PR do?:

This PR adds in additional metadata into the devfile/api typescript package. The metadata it uses is taken from the crds:

export const devworkspaceApiVersion = 'workspace.devfile.io/v1alpha2';
export const devworkspaceGroup = 'workspace.devfile.io';
export const devworkspaceKind = 'DevWorkspace';
export const devworkspacePlural = 'devworkspaces';
export const devworkspaceSingular = 'devworkspace';
export const devworkspaceVersions = ['v1alpha1', 'v1alpha2'];
export const devworkspaceLatestVersion = 'v1alpha2';
    
export const devworkspacetemplateApiVersion = 'workspace.devfile.io/v1alpha2';
export const devworkspacetemplateGroup = 'workspace.devfile.io';
export const devworkspacetemplateKind = 'DevWorkspaceTemplate';
export const devworkspacetemplatePlural = 'devworkspacetemplates';
export const devworkspacetemplateSingular = 'devworkspacetemplate';
export const devworkspacetemplateVersions = ['v1alpha1', 'v1alpha2'];
export const devworkspacetemplateLatestVersion = 'v1alpha2';

Which issue(s) this PR fixes:

#609

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer:

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested but the info from the description seems to be more than enough.

@openshift-ci
Copy link

openshift-ci bot commented Sep 17, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amisevsk, JPinkney, sleshchenko

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants