Fix default value of buildContext to PROJECT_SOURCE #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feloy
requested review from
amisevsk,
davidfestal and
sleshchenko
as code owners
amisevsk
approved these changes
Nov 24, 2021
maysunfaisal
previously approved these changes
Nov 24, 2021
maysunfaisal
approved these changes
Nov 25, 2021
feloy
force-pushed
the
fix-project-root
branch
from
c2a594f to
1a7b648
Compare
feloy
force-pushed
the
fix-project-root
branch
from
1a7b648 to
ed43396
Compare
kadel
reviewed
Feb 22, 2022
| @@ -43,7 +43,7 @@ type DockerfileSrc struct { | |||
|
|
|||
| // +devfile:getter:generate | |||
| type Dockerfile struct { | |||
| // Path of source directory to establish build context. Defaults to ${PROJECT_ROOT} in the container | |||
| // Path of source directory to establish build context. Defaults to ${PROJECTS_ROOT} in the container | |||
There was a problem hiding this comment.
+1 We are planning to deprecate PROJECT_ROOT
l0rd
requested changes
Mar 8, 2022
There was a problem hiding this comment.
+1 to @kadel. We should deprecate the use of $PROJECTS_ROOT. See #681 (comment) and #679 ("Deprecate PROJECTS_ROOT and move to use PROJECT_SOURCE")
kadel
changed the title
Signed-off-by: Philippe Martin <phmartin@redhat.com>
Signed-off-by: Philippe Martin <phmartin@redhat.com>
Signed-off-by: Tomas Kral <tkral@redhat.com>
Signed-off-by: Tomas Kral <tkral@redhat.com>
amisevsk
approved these changes
Mar 9, 2022
l0rd
approved these changes
Mar 11, 2022
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, feloy, l0rd, maysunfaisal The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
The PR fixes a comment indicating a wrong environment variable name.
Which issue(s) this PR fixes:
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
How to test changes / Special notes to the reviewer: