docs: adding contribution guidelines #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-hoang
requested review from
amisevsk,
yangcao77 and
johnmcollier
as code owners
johnmcollier
approved these changes
Apr 12, 2022
yangcao77
requested changes
Apr 13, 2022
amisevsk
reviewed
Apr 13, 2022
Signed-off-by: Michael Hoang <mhoang@redhat.com>
mike-hoang
force-pushed
the
docs/contributing
branch
from
93d1004
to
e7bd083
Compare
amisevsk
approved these changes
Apr 19, 2022
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, johnmcollier, mike-hoang, yangcao77 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Michael Hoang <mhoang@redhat.com>
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Hoang mhoang@redhat.com
What does this PR do?:
Adds a contributing file which is a requirement for CNCF onboarding
Which issue(s) this PR fixes:
#772
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
How to test changes / Special notes to the reviewer: