Cherry-pick changes from #1115 to 0.21.x branch #1116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid issues with self-signed certificates on git repositories, avoid use of go-git (which would require configuring additional CA bundles) and instead delegate to the git binary, which respects additional bundles automatically. The main cause for failure is go-git attempting to list references in a remote, which can fail due to untrusted certificates. Instead, we rely on the git binary to determine if a checkoutFrom.revision is a local/remote branch, tag, or hash. Signed-off-by: Angel Misevski <amisevsk@redhat.com> (cherry picked from commit d3897be)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Cherry-pick changes from #1115 to 0.21.x branch
What issues does this PR fix or reference?
#1114 in 0.21.x
Is it tested? How?
See original PR discussion.
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che