fix: ignore order of volumeMounts when comparing deployments #860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since support for subpath automount volumes was added, the comparison function used to ignore the order of volumeMounts in a deployment is no longer valid, as multiple volumeMounts can use the same volume. This can result in spurious changes to the deployment's spec, if the operator reads volumes in a random order. To fix this, also compare mountPath and subPath. The comparison function for other slices is unchanged, as in those cases the name is a key in the list and must be unique. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
changed the title
ibuziuk
approved these changes
Jun 6, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, ibuziuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Since support for subpath automount volumes was added, the comparison function used to ignore the order of volumeMounts in a deployment is no use the same volume. This can result in spurious changes to the deployment's spec, if the operator reads volumes in a random order.
To fix this, also compare mountPath and subPath. The comparison function for other slices is unchanged, as in those cases the name is a key in the list and must be unique.
What issues does this PR fix or reference?
Closes #859
Is it tested? How?
Test using reproducer in issue.
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che