Cherry-pick minor fixes from open PRs #960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Kubernetes 1.24, serviceaccounttoken secrets are no longer created
by default, and so this method cannot be used to login as the workspace
serviceaccount when running locally.
Instead, it's possible to use
kubectl create token <sa-name> -n <namespace>
to get the token used for the serviceaccount.
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Recent versions of Kubernetes do not automatically mount image pull secrets to serviceaccounts, meaning that most workspace starts idle for 5 seconds waiting for something that is not going to happen. Instead we scope the check for waiting for image pull secrets to only be performed when running on OpenShift. On OpenShift, there is a race between the controller and the cluster API, where sometimes DWO creates a deployment that is immediately updated with image pull secrets, slowing workspace start due to the workspace pod needing to terminate. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Codecov ReportBase: 49.43% // Head: 49.43% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #960 +/- ##
=======================================
Coverage 49.43% 49.43%
=======================================
Files 38 38
Lines 2405 2405
=======================================
Hits 1189 1189
Misses 1093 1093
Partials 123 123 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
AObuchow
approved these changes
Oct 27, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, AObuchow The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Cherry-picks two quality-of-life improvements from open PRs in order to merge them sooner:
make run/make debugwhen running on Kubernetes >=1.24).What issues does this PR fix or reference?
N/A
Is it tested? How?
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che