Skip to content

Conversation

jc-berger
Copy link
Contributor

Fixes #379.

For SME review, please take notes of the comments I left, specifically directing attention to content areas where I'll rely more heavily on SME input and confirmation. Thanks!

@jc-berger jc-berger added the documentation Improvements or additions to documentation label Jul 1, 2021
@jc-berger jc-berger self-assigned this Jul 1, 2021
jc-berger and others added 7 commits July 22, 2021 14:32
Co-authored-by: Rolfe Dlugy-Hegwer <rolfedh@users.noreply.github.com>
Co-authored-by: Rolfe Dlugy-Hegwer <rolfedh@users.noreply.github.com>
Co-authored-by: Rolfe Dlugy-Hegwer <rolfedh@users.noreply.github.com>
Co-authored-by: Rolfe Dlugy-Hegwer <rolfedh@users.noreply.github.com>
Co-authored-by: Rolfe Dlugy-Hegwer <rolfedh@users.noreply.github.com>
Co-authored-by: Rolfe Dlugy-Hegwer <rolfedh@users.noreply.github.com>
Co-authored-by: Rolfe Dlugy-Hegwer <rolfedh@users.noreply.github.com>
@jc-berger
Copy link
Contributor Author

@elsony or @rkratky I've addressed the dev and doc reviews. If either of you could take a look and merge if you think it looks good, thanks!

Copy link
Contributor

@elsony elsony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 28, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 28, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elsony, jc-berger

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elsony elsony merged commit 63a0998 into devfile:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Landing page for devfile website
5 participants