Skip to content

Modify index generator validator #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2021
Merged

Modify index generator validator #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2469e95
feat: modify index generator validator
GeekArthur May 13, 2021
d9dad94
test: add unit test
GeekArthur May 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions index/generator/library/library.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ func validateIndexComponent(indexComponent schema.Schema, componentType schema.D
if indexComponent.Git == nil {
return fmt.Errorf("index component git is empty")
}
if len(indexComponent.Git.Remotes) > 1 {
return fmt.Errorf("index component has multiple remotes")
}
}

return nil
Expand Down
14 changes: 14 additions & 0 deletions index/generator/library/library_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,20 @@ func TestValidateIndexComponent(t *testing.T) {
schema.SampleDevfileType,
false,
},
{
"Case 7: test index component git has multiple remotes",
schema.Schema{
Name: "nodejs",
Git: &schema.Git{
Remotes: map[string]string{
"origin": "https://github.com/redhat-developer/devfile-sample",
"test": "https://github.com/redhat-developer/test",
},
},
},
schema.SampleDevfileType,
true,
},
}

for _, tt := range tests {
Expand Down