Skip to content

Conversation

ivictbor
Copy link
Contributor

@ivictbor ivictbor commented Apr 1, 2025

No description provided.

SerVitasik and others added 30 commits March 18, 2025 11:50
docs: add Microsoft OAuth adapter installation and configuration inst…
docs: Add Keycloak and GitHub OAuth adapters to documentation
feat: add open and close methods for dialog component
fix: remove unset option from arrays select inputs
Astaldos and others added 21 commits March 27, 2025 11:56
fix: add option to turn enum and foreign resource filter into singleselect
feat: implement and/or operators for filters
… layout and responsiveness; clean up ResourceListTable rendering
docs: Add documentation for InlineCreatePlugin and ListInPlaceEditPlugin
@ivictbor ivictbor requested a review from Copilot April 1, 2025 12:16
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces updates and refinements to both the AdminForth documentation and the underlying data connector implementations. The changes include updates to documentation examples for standard pages, actions, hooks, and custom pages; improvements in filter handling across multiple data connectors; and additions to the blog content related to authentication and keycloak setup.

Reviewed Changes

Copilot reviewed 64 out of 64 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
adminforth/documentation/docs/tutorial/03-Customization/13-standardPagesTuning.md Removed an image column from page configuration and updated the multiselect documentation example.
adminforth/documentation/docs/tutorial/11-dataApi.md Updated an API example to include a filter combining email and createdAt conditions.
adminforth/documentation/docs/tutorial/07-alert.md Updated Vue component examples with styling classes and example headings.
adminforth/documentation/docs/tutorial/04-hooks.md Revised hook examples with modifications to parameter names and return values.
(Various data connectors) Refactored filter handling to support AND/OR conditions consistently across SQLite, Postgres, MySQL, Mongo, and Clickhouse.
Blog files (tags.yml, authors.yml, 2025-03-25-keycloack) Added new metadata and content related to keycloak and authentication.
Comments suppressed due to low confidence (3)

adminforth/documentation/docs/tutorial/11-dataApi.md:119

  • The combined condition using Filters.AND with LT('createdAt', '2024-01-01...') and GTE('createdAt', '2025-01-01...') is contradictory. Consider revising the logic to correctly capture records not created in 2024.
Filters.AND([    Filters.LT('createdAt', '2024-01-01T00:00:00.000Z'),    Filters.GTE('createdAt', '2025-01-01T00:00:00.000Z')])

adminforth/documentation/docs/tutorial/04-hooks.md:103

  • Returning only { ok: true } in the create hook may not propagate the modified record. It might be necessary to return the updated record (e.g., { ok: true, record }) to ensure subsequent logic receives the correct data.
return { ok: true }

adminforth/documentation/docs/tutorial/07-alert.md:37

  • The heading contains a typo. Consider changing 'Ussage example' to 'Usage example'.
## Ussage example

…ndardPagesTuning.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ivictbor ivictbor merged commit dd07326 into main Apr 1, 2025
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants