Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop client #2

Closed
avelino opened this issue Dec 12, 2018 · 7 comments · Fixed by #69
Closed

Desktop client #2

avelino opened this issue Dec 12, 2018 · 7 comments · Fixed by #69

Comments

@avelino
Copy link

avelino commented Dec 12, 2018

https://electronjs.org/

@brunolemos
Copy link
Member

brunolemos commented Dec 12, 2018

It's planned!

I submitted the ios app yesterday, the android is next, and I'll experiment with electron in a few days.

I'd like to make it work both ways as a "desktop" mode and as a menubar app.

Contributions welcome.

@brunolemos
Copy link
Member

It would be even better to make it work with react-native-macos and react-native-windows, since it already works with react-native-web.

@avelino avelino changed the title desktop client (electron) desktop client Dec 12, 2018
@kadamwhite
Copy link

The first thing I did when I heard about this project today was to wrap it with nativefier, which lets you quickly spin up an electron-wrapped version that can act in desktop app-y sorts of ways. Might be a nice stopgap, I think that's what octobox recommended as well if I recall correctly. (Amazing project, by the way!)

@brunolemos brunolemos added this to To do in DevHub Dec 16, 2018
@amorist amorist mentioned this issue Dec 17, 2018
4 tasks
@brunolemos brunolemos moved this from To do to In progress in DevHub Dec 18, 2018
@brunolemos brunolemos pinned this issue Dec 18, 2018
@brunolemos brunolemos changed the title desktop client Desktop client Dec 18, 2018
@brunolemos brunolemos added this to the v0.41.0 milestone Dec 22, 2018
@brunolemos brunolemos mentioned this issue Dec 26, 2018
53 tasks
@brunolemos
Copy link
Member

brunolemos commented Dec 28, 2018

Having two issues on #69 that I'd really appreciate some help:

  • [Windows] Fix devhub:// protocol on dev mode
  • [Windows] Fix login (devhub:// is opening a new browserwindow and not logging in)

EDIT: Fixed.

@amorist
Copy link
Contributor

amorist commented Dec 28, 2018

Having two issues on #69 that I'd really appreciate some help:

  • [Windows] Fix devhub:// protocol on dev mode
  • [Windows] Fix login (devhub:// is opening a new browserwindow and not logging in)

Sorry, I don't have windows.

DevHub automation moved this from In progress to Done Dec 30, 2018
@brunolemos
Copy link
Member

brunolemos commented Dec 30, 2018

[pre-release] First versions of the Desktop apps are now available! Download here: https://github.com/devhubapp/devhub/releases

MacOS and Windows worked great on my tests.
The linux app didn't work as expected on my virtual machine. Opened #79, help wanted.

Please test and let me know before I tweet about it in a couple days.

cc @joulse, @wisnuprama, @webron, @PGScully, @luongvo, @nblackburn, @amorist, @Suburbanno, @langyo

brunolemos added a commit that referenced this issue Jan 4, 2019
@brunolemos
Copy link
Member

Tweeted about it: https://twitter.com/brunolemos/status/1082666519866368001?s=20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
DevHub
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants