Skip to content

Add support for new September 2022 devices #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 13, 2022

Conversation

Zandor300
Copy link
Member

@Zandor300 Zandor300 commented Sep 7, 2022

iPhone

  • iPhone 14
  • iPhone 14 Plus
  • iPhone 14 Pro
  • iPhone 14 Pro Max

Apple Watch

  • Apple Watch Series 7 (Still missing from DeviceKit since last year)
  • Apple Watch Series 8
  • Apple Watch SE (2nd generation)
  • Apple Watch Ultra

Fixes #323
Fixes #326
Fixes #306

@github-actions
Copy link

github-actions bot commented Sep 7, 2022

3 Warnings
⚠️ Plist changed, don't forget to localize your plist values
⚠️ Source/Device.generated.swift#L251 - TODOs should be resolved ()).
todo Device.generated.swift:251
⚠️ Source/Device.generated.swift#L253 - TODOs should be resolved ()).
todo Device.generated.swift:253

SwiftLint found issues

Warnings

File Line Reason
Device.generated.swift 187 TODOs should be resolved ()). (todo)
Device.generated.swift 189 TODOs should be resolved ()). (todo)
Device.generated.swift 191 TODOs should be resolved ()). (todo)
Device.generated.swift 193 TODOs should be resolved ()). (todo)
Device.generated.swift 195 TODOs should be resolved ()). (todo)
Device.generated.swift 197 TODOs should be resolved ()). (todo)
Device.generated.swift 199 TODOs should be resolved ()). (todo)
Device.generated.swift 201 TODOs should be resolved ()). (todo)
Device.generated.swift 251 TODOs should be resolved ()). (todo)
Device.generated.swift 253 TODOs should be resolved ()). (todo)
Device.generated.swift 409 TODOs should be resolved ()). (todo)
Device.generated.swift 411 TODOs should be resolved ()). (todo)
Device.generated.swift 413 TODOs should be resolved ()). (todo)
Device.generated.swift 415 TODOs should be resolved ()). (todo)
Device.generated.swift 417 TODOs should be resolved ()). (todo)
Device.generated.swift 419 TODOs should be resolved ()). (todo)
Device.generated.swift 421 TODOs should be resolved ()). (todo)
Device.generated.swift 423 TODOs should be resolved ()). (todo)
Device.generated.swift 425 TODOs should be resolved ()). (todo)
Device.generated.swift 427 TODOs should be resolved ()). (todo)

Generated by 🚫 Danger

@jimmycooks9
Copy link

hi @denisenepraunig - I'm sure you're busy but if could you find some time to review @Zandor300's commit when you get a chance it would be amazing with iOS 16, macOS 12.4, watchOS 9 and such releasing today, in addition to Xcode 14 officially releasing.

Thank you.

p.s. I've reviewed.. LGTM.

Copy link
Collaborator

@denisenepraunig denisenepraunig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Zandor300!

@denisenepraunig
Copy link
Collaborator

@jimmycooks9 - sorry for being late...

@denisenepraunig denisenepraunig merged commit d48a843 into master Sep 13, 2022
@Zandor300 Zandor300 deleted the feature/devices-september-2022 branch September 14, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add New Devices - iPhone 14, Apple Watch SE (2nd Gen., Apple Watch Ultra / Series 8 Add Watch Series 7 Add support for Apple Watch Series 7
3 participants