Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ICON REQUEST]: JetBrains Products #1125

Closed
1 task done
Kek5chen opened this issue Apr 1, 2022 · 14 comments
Closed
1 task done

[ICON REQUEST]: JetBrains Products #1125

Kek5chen opened this issue Apr 1, 2022 · 14 comments
Labels
in-develop The fix/feature is present in `develop` branch but not merged into `master` yet request:icon When requesting a new icon to be added to the collection or a refactor use this label in your issue

Comments

@Kek5chen
Copy link
Contributor

Kek5chen commented Apr 1, 2022

I have searched through the issues and didn't find my problem.

  • Confirm

About the icon

JetBrains has great products and provides them with great care.

Links and sources

Here you can see the SVGs of all their developer tools:
https://www.jetbrains.com/products/

I've done a bit of own work but since contributing to this repository is very strict and I am afraid to make too many mistakes I forked it, placed some icons and pushed it to my fork. You can see the changes here:
Kek5chen@0a06ff5

Icons included:
CLion
DataGrip
IntelliJ
PhpStorm
PyCharm
Rider
WebStorm

Some icons i only updated, but I only updated the original files. The others, except plain, seemed outdated as there is no actual wordmark for the products officially available anywhere.

Would you like me to create a PR for maintainers to modify to suit the repository guidelines?

Additional information

No response

@Kek5chen Kek5chen added the request:icon When requesting a new icon to be added to the collection or a refactor use this label in your issue label Apr 1, 2022
@Snailedlt
Copy link
Collaborator

Hey, create a PR so we can get this one going :)
Jetbrains icons definitely need updating

@Kek5chen
Copy link
Contributor Author

Kek5chen commented May 5, 2022

Alright, i opened a pr. I do not know if everything matches what you were asking for but it should be a good starting point

@Snailedlt
Copy link
Collaborator

@kilian-paquier You wanna try to tackle this one?

@kilianpaquier
Copy link
Contributor

My favorite products ❤️ Will take care of that one yep, I'll add "fleet" too, their next IDE (multilingual like IntelliJ)

@kilianpaquier
Copy link
Contributor

@Kek5chen Hello, thank you for your contribution, even if it's in your fork repository. I'm going to use your original's icons (with small modifications) and tag you as co-author if it's ok for you.

@Kek5chen
Copy link
Contributor Author

sure thing, thanks. i'm glad i could help somewhat. i'm also happy that i can finally close the repository.

@kilianpaquier
Copy link
Contributor

Don't close it too soon, I didn't copy all the icons yet 😁

@Kek5chen
Copy link
Contributor Author

of course not. i'll wait for this issue to be resolved first

@kilianpaquier
Copy link
Contributor

kilianpaquier commented Jul 24, 2022

@Snailedlt @Kek5chen Maybe we could define a main color for our plain icons, instead of black ?

@Snailedlt
Copy link
Collaborator

@kilian-paquier If you do, make sure it's one from their color pallette here:
https://www.jetbrains.com/company/brand/

@kilianpaquier
Copy link
Contributor

kilianpaquier commented Jul 24, 2022

Ok I'm going to look into this.

Also, I found this : https://github.com/JetBrains/logos
I'm going to use those icons for the PR's, that's why I made "draft" the opened ones.

I just saw that there's also SVG links in the link you posted @Snailedlt. Thank you, i'm going to use it too.

@Snailedlt
Copy link
Collaborator

@kilian-paquier yeah everything you need should be in that link I sent :)
TOS is there too

@kilianpaquier
Copy link
Contributor

All PR's created

Snailedlt pushed a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
* update icon: webstorm (original, plain, plain-wordmark) - contributes to devicons#1125

* webstorm | added original-wordmark
Snailedlt pushed a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
* update icon: rubymine (original, plain, plain-wordmark) - contributes to devicons#1125

* rubymine | added original-wordmark
Snailedlt pushed a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
* update icon: pycharm (original, plain, plain-wordmark) - contributes to devicons#1125

* pycharm | added original-wordmark
Snailedlt pushed a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
* update icon: rider (original, plain, plain-wordmark) - contributes to devicons#1125

* rider | added original-wordmark
Snailedlt pushed a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
… to devicons#1125 (devicons#1294)

Co-authored-by: Kek5chen <Kek5chen@users.noreply.github.com>

Co-authored-by: Kek5chen <Kek5chen@users.noreply.github.com>
Snailedlt pushed a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
* update icon: intellij (original, plain, plain-wordmark) - contributes to devicons#1125

Co-authored-by: Kek5chen <Kek5chen@users.noreply.github.com>

* intellij| added java tag

Co-authored-by: Kek5chen <Kek5chen@users.noreply.github.com>
Snailedlt added a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
* new icon: datagrip (original, plain, plain-wordmark) - contributes to devicons#1125

Co-authored-by: Kek5chen <Kek5chen@users.noreply.github.com>

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

* moved object in devicon.json

Co-authored-by: Kek5chen <Kek5chen@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt pushed a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
Snailedlt pushed a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
…evicons#1321)

* new icon: ktor (original, original-wordmark, plain, plain-wordmark) - contributes to devicons#1125

* ktor| moved object in devicon.json
Snailedlt added a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
* update icon: clion (original, plain) - contributes to devicons#1125

* clion| added original svg

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt pushed a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
* update icon: webstorm (original, plain, plain-wordmark) - contributes to devicons#1125

* webstorm | added original-wordmark
Snailedlt pushed a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
* update icon: rubymine (original, plain, plain-wordmark) - contributes to devicons#1125

* rubymine | added original-wordmark
Snailedlt pushed a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
* update icon: pycharm (original, plain, plain-wordmark) - contributes to devicons#1125

* pycharm | added original-wordmark
Snailedlt pushed a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
* update icon: rider (original, plain, plain-wordmark) - contributes to devicons#1125

* rider | added original-wordmark
Snailedlt pushed a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
… to devicons#1125 (devicons#1294)

Co-authored-by: Kek5chen <Kek5chen@users.noreply.github.com>

Co-authored-by: Kek5chen <Kek5chen@users.noreply.github.com>
Snailedlt pushed a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
* update icon: intellij (original, plain, plain-wordmark) - contributes to devicons#1125

Co-authored-by: Kek5chen <Kek5chen@users.noreply.github.com>

* intellij| added java tag

Co-authored-by: Kek5chen <Kek5chen@users.noreply.github.com>
Snailedlt added a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
* new icon: datagrip (original, plain, plain-wordmark) - contributes to devicons#1125

Co-authored-by: Kek5chen <Kek5chen@users.noreply.github.com>

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

* moved object in devicon.json

Co-authored-by: Kek5chen <Kek5chen@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt pushed a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
Snailedlt pushed a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
…evicons#1321)

* new icon: ktor (original, original-wordmark, plain, plain-wordmark) - contributes to devicons#1125

* ktor| moved object in devicon.json
Snailedlt added a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
* update icon: clion (original, plain) - contributes to devicons#1125

* clion| added original svg

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt pushed a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
* update icon: webstorm (original, plain, plain-wordmark) - contributes to devicons#1125

* webstorm | added original-wordmark
Snailedlt pushed a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
* update icon: rubymine (original, plain, plain-wordmark) - contributes to devicons#1125

* rubymine | added original-wordmark
Snailedlt pushed a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
* update icon: pycharm (original, plain, plain-wordmark) - contributes to devicons#1125

* pycharm | added original-wordmark
Snailedlt pushed a commit to Snailedlt/devicon that referenced this issue Oct 15, 2022
* update icon: rider (original, plain, plain-wordmark) - contributes to devicons#1125

* rider | added original-wordmark
@github-actions github-actions bot closed this as completed Feb 2, 2023
@weh weh mentioned this issue Jan 18, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-develop The fix/feature is present in `develop` branch but not merged into `master` yet request:icon When requesting a new icon to be added to the collection or a refactor use this label in your issue
Projects
None yet
Development

No branches or pull requests

3 participants