Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: datagrip (original, plain, plain-wordmark) #1292

Merged
merged 4 commits into from
Jul 29, 2022
Merged

new icon: datagrip (original, plain, plain-wordmark) #1292

merged 4 commits into from
Jul 29, 2022

Conversation

kilianpaquier
Copy link
Contributor

@kilianpaquier kilianpaquier commented Jul 24, 2022 •
edited
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR contributes to #1125

Link to prove your SVG is correct and up-to-date.

https://www.jetbrains.com/fr-fr/datagrip/

@kilianpaquier kilianpaquier marked this pull request as draft July 24, 2022 11:21
@Kek5chen
new icon: datagrip (original, plain, plain-wordmark) - contributes to #…
abb1e50 
…1125

Co-authored-by: Kek5chen <Kek5chen@users.noreply.github.com>
@kilianpaquier kilianpaquier changed the title new icon: datagrip (original, plain) new icon: datagrip (original, plain, plain-wordmark) Jul 24, 2022
@kilianpaquier kilianpaquier marked this pull request as ready for review July 24, 2022 17:16
Snailedlt
Snailedlt requested changes Jul 25, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested some more tags

devicon.json Outdated Show resolved Hide resolved
@kilianpaquier @Snailedlt
Update devicon.json
a3cd9af 
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 25, 2022
Snailedlt
Snailedlt requested changes Jul 28, 2022
View reviewed changes
devicon.json Show resolved Hide resolved
@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 28, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt
Snailedlt approved these changes Jul 28, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️

Perfection is not attainable, but if we chase perfection we can catch excellence.
- Vince Lombardi

@Snailedlt Snailedlt merged commit 9430565 into devicons:develop Jul 29, 2022
@kilianpaquier kilianpaquier deleted the datagrip branch August 18, 2022 17:28
@kilianpaquier
Copy link
Contributor Author

@Snailedlt Here too

Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@kilianpaquier @Kek5chen @Snailedlt
new icon: datagrip (original, plain, plain-wordmark) (devicons#1292)
50a06ff 
* new icon: datagrip (original, plain, plain-wordmark) - contributes to devicons#1125

Co-authored-by: Kek5chen <Kek5chen@users.noreply.github.com>

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

* moved object in devicon.json

Co-authored-by: Kek5chen <Kek5chen@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@kilianpaquier @Kek5chen @Snailedlt
new icon: datagrip (original, plain, plain-wordmark) (devicons#1292)
39ef63f 
* new icon: datagrip (original, plain, plain-wordmark) - contributes to devicons#1125

Co-authored-by: Kek5chen <Kek5chen@users.noreply.github.com>

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

* moved object in devicon.json

Co-authored-by: Kek5chen <Kek5chen@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@kilianpaquier @Kek5chen @Snailedlt
new icon: datagrip (original, plain, plain-wordmark) (devicons#1292)
b306496 
* new icon: datagrip (original, plain, plain-wordmark) - contributes to devicons#1125

Co-authored-by: Kek5chen <Kek5chen@users.noreply.github.com>

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

* moved object in devicon.json

Co-authored-by: Kek5chen <Kek5chen@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snailedlt Snailedlt Snailedlt approved these changes

Assignees
No one assigned
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kilianpaquier @Snailedlt