-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: azuredevops (original, plain) #1289
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The folder, icons and PR title should be renamed to azuredevops
. See the Naming-Conventions wiki for more info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's also some conflicts that need to be solved before we can merge this
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✔️
@kilian-paquier It hard to keep track of everything and this can lead to mistake when new elements are not added at the correct alphabetic position. I think this isn't the first time you added a new element to Because of these misplacements I had an had time fixing merge conflicts in my own PRs. So if you can ensure for your future contributions that you place new entries at the right alphabetic place in the @Snailedlt Maybe It will be another element to add to the checklist when reviewers look at PRs, and maybe a good element to add to documentation for new contributors. Have a good day guys ☀️ |
@BenSouchet Ohh yeah, didn't notice that. My bad for merging. On the note of adding this to the reviewing process, I agree. I think we can even do one better, and automatically sort the devicon.js file with some type of linter. Should be possible to do before merge, so we avoid merge conflicts in the future. I'll make an issue on this once I get back home, so we can discuss it further :) Thanks for letting me know |
@Snailedlt I already created this Feature Request #1327 , so everyone can comment / add elements or feedback on the idea. And yes, automatically sort the JSON file would be great since some entries are already misplaced. |
* new icon: azuredevops (original, plain) - fix devicons#1281 * Update devicon.json Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
* new icon: azuredevops (original, plain) - fix devicons#1281 * Update devicon.json Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
* new icon: azuredevops (original, plain) - fix devicons#1281 * Update devicon.json Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes #1281
Link to prove your SVG is correct and up-to-date.
See #1281.