Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: azuredevops (original, plain) #1289

Merged
merged 3 commits into from
Jul 27, 2022
Merged

new icon: azuredevops (original, plain) #1289

merged 3 commits into from
Jul 27, 2022

Conversation

kilianpaquier
Copy link
Contributor

@kilianpaquier kilianpaquier commented Jul 24, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1281

Link to prove your SVG is correct and up-to-date.

See #1281.

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The folder, icons and PR title should be renamed to azuredevops. See the Naming-Conventions wiki for more info

@kilianpaquier kilianpaquier changed the title new icon: azure-devops (original, plain) new icon: azuredevops (original, plain) Jul 26, 2022
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also some conflicts that need to be solved before we can merge this

devicon.json Outdated Show resolved Hide resolved
@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 26, 2022
kilianpaquier and others added 2 commits July 27, 2022 20:31
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@Snailedlt Snailedlt added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jul 27, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️

@Snailedlt Snailedlt merged commit 5fb9cb5 into devicons:develop Jul 27, 2022
@BenSouchet
Copy link
Contributor

@kilian-paquier
Please, make sure, when you add a new entry in the devicon.json file that you add it at the correct position in the file.
Elements order need to reflect the icons/ folder, in this PR you added azuredevops between clojurescript and cloudflare.

It hard to keep track of everything and this can lead to mistake when new elements are not added at the correct alphabetic position.

I think this isn't the first time you added a new element to devicon.json at "random" possition, I have seen lumen placed between ceylon and chrome.

Because of these misplacements I had an had time fixing merge conflicts in my own PRs.

So if you can ensure for your future contributions that you place new entries at the right alphabetic place in the devicon.json file, thanks.

@Snailedlt Maybe It will be another element to add to the checklist when reviewers look at PRs, and maybe a good element to add to documentation for new contributors.

Have a good day guys ☀️

@Snailedlt
Copy link
Collaborator

@BenSouchet Ohh yeah, didn't notice that. My bad for merging.

On the note of adding this to the reviewing process, I agree. I think we can even do one better, and automatically sort the devicon.js file with some type of linter. Should be possible to do before merge, so we avoid merge conflicts in the future.

I'll make an issue on this once I get back home, so we can discuss it further :)

Thanks for letting me know

@BenSouchet
Copy link
Contributor

@Snailedlt I already created this Feature Request #1327 , so everyone can comment / add elements or feedback on the idea.

And yes, automatically sort the JSON file would be great since some entries are already misplaced.
So we could iterate on a proper ordered file for future contributions, and avoid continuing to misplace entries.

@kilianpaquier kilianpaquier deleted the azure-devops branch July 28, 2022 20:48
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* new icon: azuredevops (original, plain) - fix devicons#1281

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* new icon: azuredevops (original, plain) - fix devicons#1281

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* new icon: azuredevops (original, plain) - fix devicons#1281

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants