Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 set up local mongo db connection #14

Merged

Conversation

RamadanCRaji
Copy link
Contributor

finished adding a local Mongo instance

…oDB-connection' into 2-Set-up-local-MongoDB-connection

i
added docker compose file and modified db string in .env.example
@vercel
Copy link

vercel bot commented Sep 20, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @devlarabar on Vercel.

@devlarabar first needs to authorize it.

Copy link
Owner

@devlarabar devlarabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! It will be super helpful for all of us while working in our locals.

Before I merge, I think it would probably be best to delete the package-lock.json in the root since it contains no dependencies and isn't entirely necessary. Could you also add the password in DB_STRING in the .env.example? It would eliminate an extra step for folks who want to work on the app.

Thanks so much, I appreciate all your hard work on this!

@RamadanCRaji
Copy link
Contributor Author

okay. I will go ahead and fix it.

@RamadanCRaji RamadanCRaji marked this pull request as ready for review September 21, 2023 13:57
Copy link
Owner

@devlarabar devlarabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@devlarabar devlarabar merged commit a59a125 into devlarabar:main Sep 21, 2023
@RamadanCRaji RamadanCRaji deleted the 2-Set-up-local-MongoDB-connection branch October 17, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants