-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete "Outreach" form #17
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @devlarabar on Vercel. @devlarabar first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for working on this! I have a couple notes. I see that there's a merge conflict, this was likely caused by not pulling the most recent changes before creating your PR. Could you please run git pull origin main
and resolve?
There's also a typo on line 190, resonse
should be response
: value={outreach.responseDetails.resonseYes}
.
Once those changes are made, I'll review again and test that everything works as intended 👍
I addressed the merge conflict and fixed the typo. Additionally, updated classNames to reflect the existing "checkbox". |
It looks like we both made PRs at the exact same time, so there are still (different) conflicts unfortunately. If you wouldn't mind resolving again, I'll go ahead and merge afterward! I really appreciate your help! |
Sounds good. I'll take another look later today when I have some time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for working on this!
Work Completed
Ideas for further development (Updated 10/08/2023)