Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete "Outreach" form #17

Merged
merged 6 commits into from
Oct 12, 2023
Merged

Conversation

Kirk-Esterline
Copy link
Contributor

Work Completed

  • Added the remaining "responseDetails" and "clientWork" elements to the "Outreach form.
  • Elements were added in the same manner as the existing elements to create a longer form.
  • Headings were also added to separate between contact, response, and client work.

Ideas for further development (Updated 10/08/2023)

  • Add a check for whether the client was contacted before adding response or work details.
  • ResponseYes is now currently a checkbox. Consider the response to be a drop down of "Yes", "No", and "Maybe Later". This might give the user a better indication of whether they should reach out to the client later.

@vercel
Copy link

vercel bot commented Oct 8, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @devlarabar on Vercel.

@devlarabar first needs to authorize it.

Copy link
Owner

@devlarabar devlarabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for working on this! I have a couple notes. I see that there's a merge conflict, this was likely caused by not pulling the most recent changes before creating your PR. Could you please run git pull origin main and resolve?

There's also a typo on line 190, resonse should be response: value={outreach.responseDetails.resonseYes}.

Once those changes are made, I'll review again and test that everything works as intended 👍

@Kirk-Esterline
Copy link
Contributor Author

I addressed the merge conflict and fixed the typo. Additionally, updated classNames to reflect the existing "checkbox".

@devlarabar
Copy link
Owner

It looks like we both made PRs at the exact same time, so there are still (different) conflicts unfortunately. If you wouldn't mind resolving again, I'll go ahead and merge afterward! I really appreciate your help!

@Kirk-Esterline
Copy link
Contributor Author

Sounds good. I'll take another look later today when I have some time.

Copy link
Owner

@devlarabar devlarabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for working on this!

@devlarabar devlarabar merged commit 0840e41 into devlarabar:main Oct 12, 2023
@Kirk-Esterline Kirk-Esterline deleted the my-feature branch January 15, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants