added dropdown menu #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @devlarabar on Vercel. @devlarabar first needs to authorize it. |
devlarabar
reviewed
Oct 17, 2023
| {isOpen && ( | ||
| <div className="w-40 z-[1] border-secondary rounded-lg absolute left-full mt-2 origin-top-right rounded-md bg-primary shadow-lg ring-1 ring-black ring-opacity-5 focus:outline-none shadow"> | ||
| <a className="group flex items-center px-4 py-2 text-sm text-CCCFD2-700 hover:bg-[rgb(205,213,224,0.1)] hover:text-white hover:rounded-lg"> | ||
| {" "} |
devlarabar
requested changes
Oct 17, 2023
There was a problem hiding this comment.
Functionality is great! Here are the comments we discussed at standup today:
- It would be great for consistency & design unity to make these dropdowns the same stylistically as the navigation dropdown. That means - the border, border radius, padding, and colors should match.
- Make sure you check both dark & light mode!
- When a user clicks away from the dropdown, the dropdown should close
- Capitalize the links in the dropdown
I recommend using the same code as we have on the nav dropdown, which is a pre-built component from DaisyUI. That way we get the nice subtle animation on open as well and everything matches nicely and easily.
Thank you for working on this and for being a great member of the team!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11