Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize filtering clients by business type #33

Merged
merged 4 commits into from
Nov 12, 2023

Conversation

debasishrowlo
Copy link
Contributor

Description

  • Previous filtering implementation required the client array to be duplicated into 2 state variables and required manually filtering the client list. Current implementation requires only one state variable and automatically filters the client list.
  • Bugfix: Removes duplicate business types being displayed in the filter list.

Testing

  • Duplicate business type bugfix test
    1. Create 2 clients with the same business type
    2. Click on the filter icon
    3. Assert that the business type is shown once in the dropdown.

Did you change the schema?

  • Yes
  • No

Copy link

vercel bot commented Nov 11, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @devlarabar on Vercel.

@devlarabar first needs to authorize it.

Copy link
Owner

@devlarabar devlarabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for working on this! 👍

@devlarabar devlarabar merged commit 054a39f into devlarabar:main Nov 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants