Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created profile page and layout for potential chart and data #36

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

RamadanCRaji
Copy link
Contributor

Description

created profile page and layout for potential chart and data

Copy link

vercel bot commented Nov 20, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @devlarabar on Vercel.

@devlarabar first needs to authorize it.

@RamadanCRaji RamadanCRaji marked this pull request as ready for review November 20, 2023 14:22
Copy link
Owner

@devlarabar devlarabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the grid, everything is laid out super easy to see!

I noticed a few things I think should be updated before merging - let me know if you're able to make the changes or if you'd prefer I implement them. Either is fine with me 😄

The first thing I noticed was that the colors don't change for light mode. I saw that you hard-coded some colors in here, I'd recommend against that and use the primary/secondary/etc classes instead. See tailwing.config.js for those.
Screenshot 2023-11-20 095117

The grid also doesn't adjust for mobile:
Screenshot 2023-11-20 095134

Making our app mobile-responsive is super important as we want it to be accessible on-the-go.

I would also love to see a larger gap between the grid elements, and more padding within them to be more consistent with the spacing we have on the home page! That way the different pages of the app feel more unified.

Thanks so much and really looking forward to more progress on this!

@devlarabar devlarabar merged commit edce817 into devlarabar:main Nov 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants