Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature initial design #9

Merged
merged 12 commits into from
Sep 15, 2023
Merged

Conversation

ka-lange
Copy link
Contributor

For initial design, I wanted to keep it simple and not add too much at once. I added the new light and dark color schemes to the daisyUI themes so the toggler is not affected. For this first styling pull, I focused on the homepage and client cards. I included the color scheme with tailwind classes as a reference for anyone working on the style!

Key changes:

  • add tailwind's hero icons as a client package
  • updated daisyUI color schemes to custom colors
  • client card styling including ellipsis option menu icon, divisions for each contact field
  • add ActionMenu.jsx file with user action items of sort, filter, and list view

Future issues to add:

  • functionality of client ellipsis menu and action menu items
  • phone number styling
  • addition of checkmark icon to show if client had follow up
  • addition of ActionMenu so it only shows up on the homepage (if added now, it will be added to all pages)
Screenshot 2023-09-15 at 1 25 14 PM

100freelancer (4)

@vercel
Copy link

vercel bot commented Sep 15, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @devlarabar on Vercel.

@devlarabar first needs to authorize it.

Copy link
Owner

@devlarabar devlarabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking stellar! I loved it the second I saw it. The client cards especially look so clean; the icons make everything super easy to see.

I do have one thought, it doesn't need to be added with this PR for sure but more of a note for the future. I think increasing the contrast with the hover effect on the submit button on light mode would be nice, currently it blends in a lot with the background:

Screenshot 2023-09-15 140427

I'd like for the inputs and navigation menu to have a different color than the background as well (this isn't a change you made, it was like this originally), but again, these aren't priorities. If you'd like to work on them though, let me know if you'd prefer to incorporate them into this PR or do it at some point in the future!

Thanks so much for working on this! Your eye for design is really bringing the app to life!

@ka-lange
Copy link
Contributor Author

Oh yeah I didn't even touch the add client and outreach pages yet - I can go in quick and add those to this PR because I agree!

@ka-lange
Copy link
Contributor Author

Updated PR to include initial add and outreach page styles to have more contrast and readability.
Key Changes:

  • add global styles for input fields and form submit buttons
  • add a Home link into user dropdown nav
  • add user Action Menu to home page (not functional)

One other issue I ran into is that the nav menu stays open after clicking a link but this can be a separate issue

@devlarabar devlarabar merged commit 01bda59 into devlarabar:main Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants