Skip to content

Commit e8f3774

Browse files
committed
Pages access token should always come from secrets
For additional security
1 parent 4234724 commit e8f3774

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

β€Ž.github/workflows/pages.ymlβ€Ž

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ on:
99
env:
1010
PAGES_ORGANIZATION: ${{ secrets.PAGES_ORGANIZATION }}
1111
PAGES_REPOSITORY: ${{ secrets.PAGES_REPOSITORY }}
12-
PAGES_ACCESS_TOKEN: ${{ secrets.PAGES_ACCESS_TOKEN }}
1312

1413
jobs:
1514
gh-pages:
@@ -23,14 +22,18 @@ jobs:
2322
sudo gem install bundler
2423
bundle install
2524
25+
- name: πŸ–‰ default env
26+
env:
27+
PAGES_ORGANIZATION: ${{ secrets.PAGES_ORGANIZATION }}
28+
PAGES_REPOSITORY: ${{ secrets.PAGES_REPOSITORY }}
29+
run: |
30+
echo "PAGES_ORGANIZATION=${PAGES_ORGANIZATION}" >> $GITHUB_ENV
31+
echo "PAGES_REPOSITORY=${PAGES_REPOSITORY}" >> $GITHUB_ENV
32+
2633
- name: πŸ–‰ default repo
27-
if: ${{ env.PAGES_REPOSITORY }} == ''
34+
if: env.PAGES_REPOSITORY == ''
2835
run: echo "PAGES_REPOSITORY=${GITHUB_REPOSITORY#*/}" >> $GITHUB_ENV
2936

30-
- name: πŸ–‰ default token
31-
if: env.PAGES_ACCESS_TOKEN == ''
32-
run: echo "PAGES_ACCESS_TOKEN=${{ secrets.GITHUB_TOKEN }}" >> $GITHUB_ENV
33-
3437
- name: πŸ™ build
3538
run: bundle exec jekyll build -b ${{ env.PAGES_REPOSITORY }}
3639
env:
@@ -48,7 +51,7 @@ jobs:
4851
- name: πŸš€ push
4952
uses: ad-m/github-push-action@v0.6.0
5053
with:
51-
github_token: ${{ env.PAGES_ACCESS_TOKEN }}
54+
github_token: ${{ secrets.PAGES_ACCESS_TOKEN }}
5255
repository: ${{ env.PAGES_ORGANIZATION }}/${{ env.PAGES_REPOSITORY }}
5356
branch: gh-pages
5457
force: true

0 commit comments

Comments
Β (0)