You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
doAskToContinue "Failed to run devon ${*} - do you want to continue?"
If doDevonCommand is called and fails it will ask the user to continue.
This currently made our build stalled as the automated tests ran into this situation and the build was waiting for user-input that could never happen.
We should question why this behavior has been introduced.
Maybe it makes sense if devon release calls other functions and the user might want to continue in some cases.
However, IMHO this is not a good default behavior and should only apply in very special situations.
Finally, if we keep interactive questions like this, we need to run all our tests strictly in batch mode.
Even better devonfw-ide could check if the environment can actually never provide user input (no tty present, ${CI}=true, etc.) and enable batch mode automatically in such case.
The text was updated successfully, but these errors were encountered:
This issue is about reconsidering this line of code:
ide/scripts/src/main/resources/scripts/functions
Line 328 in d72d893
If
doDevonCommand
is called and fails it will ask the user to continue.This currently made our build stalled as the automated tests ran into this situation and the build was waiting for user-input that could never happen.
We should question why this behavior has been introduced.
Maybe it makes sense if
devon release
calls other functions and the user might want to continue in some cases.However, IMHO this is not a good default behavior and should only apply in very special situations.
Finally, if we keep interactive questions like this, we need to run all our tests strictly in batch mode.
Even better devonfw-ide could check if the environment can actually never provide user input (no tty present,
${CI}=true
, etc.) and enable batch mode automatically in such case.The text was updated successfully, but these errors were encountered: