Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doDevonCommand should use doFail instead of doAskToContinue #935

Closed
hohwille opened this issue Oct 10, 2022 · 1 comment · Fixed by #936
Closed

doDevonCommand should use doFail instead of doAskToContinue #935

hohwille opened this issue Oct 10, 2022 · 1 comment · Fixed by #936
Labels
enhancement New feature or request

Comments

@hohwille
Copy link
Member

This issue is about reconsidering this line of code:

doAskToContinue "Failed to run devon ${*} - do you want to continue?"

If doDevonCommand is called and fails it will ask the user to continue.
This currently made our build stalled as the automated tests ran into this situation and the build was waiting for user-input that could never happen.

We should question why this behavior has been introduced.
Maybe it makes sense if devon release calls other functions and the user might want to continue in some cases.
However, IMHO this is not a good default behavior and should only apply in very special situations.

Finally, if we keep interactive questions like this, we need to run all our tests strictly in batch mode.
Even better devonfw-ide could check if the environment can actually never provide user input (no tty present, ${CI}=true, etc.) and enable batch mode automatically in such case.

@hohwille hohwille added the enhancement New feature or request label Oct 10, 2022
hohwille added a commit to hohwille/ide that referenced this issue Oct 10, 2022
@hohwille hohwille linked a pull request Oct 10, 2022 that will close this issue
hohwille added a commit to hohwille/ide that referenced this issue Oct 10, 2022
@hohwille
Copy link
Member Author

For the record:
These "special situations" are already using `doDevonCommandAndReturn":

doDevonCommandAndReturn build release "${@}"

So IMHO there is no need left for this doAskToContinue.
PR #936 created.

@hohwille hohwille added this to the release:2022.08.004 milestone Oct 10, 2022
@hohwille hohwille changed the title doDevonCommand reconsider doAskToContinue doDevonCommand should use doFail instead of doAskToContinue Oct 10, 2022
hohwille added a commit that referenced this issue Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant