Fix args quoting for node commandlet #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix quoting of args in array context. Use "$@" instead of "$*" for correct quoting of each single command option. Otherwise "devon node" can't take more than one argument.
hohwille
approved these changes
Sep 1, 2020
There was a problem hiding this comment.
@markusschuh thanks for pointing this out and fixing it via PR. Indeed this is the right way to do it and in other commandlets (e.g. mvn) we also use ${@} instead of ${*}. However, I also have to admit that bash confuses me with these two variants and shellcheck wants us to use ${*} in the doEcho statement (see above) since it is within double quotes.
Thanks for the fix 👍
hohwille
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix quoting of args in array context.
Use "$@" instead of "$*" for correct quoting of each single command option. Otherwise "devon node" can't take more than one argument.