Skip to content

Conversation

taik0
Copy link
Contributor

@taik0 taik0 commented May 5, 2018

No description provided.

@coveralls
Copy link

coveralls commented May 5, 2018

Pull Request Test Coverage Report for Build 84

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.124%

Totals Coverage Status
Change from base Build 82: 0.0%
Covered Lines: 724
Relevant Lines: 831

💛 - Coveralls

@kpacha
Copy link
Contributor

kpacha commented May 7, 2018

I'd rather create a new docker_deps section containing the docker run --rm -it -e "GOPATH=/go" -v "${PWD}:/go/${GOBASEDIR}" -w /go/${GOBASEDIR} lushdigital/docker-golang-dep ensure -v command and set it as a dependency for the server_build stage.

@kpacha kpacha merged commit 213bf9b into devopsfaith:master May 9, 2018
@kpacha
Copy link
Contributor

kpacha commented May 9, 2018

Great!

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants