added support for YAML conf file and changed default conf file name #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 97
💛 - Coveralls |
Closed
kpacha
reviewed
Jul 22, 2018
| "io" | ||
| "os" | ||
|
|
||
| "github.com/ghodss/yaml" |
There was a problem hiding this comment.
The package github.com/ghodss/yaml should be added to the Gopkg.toml file
|
I'm merging it despite of the failing coverage check. I'll create a issue requesting a fix for the lost coverage. Thanks for the contribution!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the config file can now be both YAML and JSON it makes sense to set the default conf file name to something generic like api2html.conf