Skip to content

refactor: improve request body type definition and normalize wallet address #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2025
Merged

refactor: improve request body type definition and normalize wallet address #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions src/routes/register.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,16 @@ import {
HttpStatusCode,
} from "../utils/errorHandler.js";


const prisma = new PrismaClient();

// Define the expected request body type for clarity and reusability
type RegisterRequestBody = {
walletAddress: string;
message: string;
signature: string;
};

export default async function registerRoute(fastify: FastifyInstance) {
// POST /register - Register a new user with wallet authentication
fastify.post("/register", {
Expand Down Expand Up @@ -42,15 +50,15 @@ export default async function registerRoute(fastify: FastifyInstance) {
},
preHandler: verifyWalletSignature,
handler: asyncHandler(async (request, reply) => {
const { walletAddress } = request.body as {
walletAddress: string;
message: string;
signature: string;
};

const { walletAddress } = request.body as RegisterRequestBody;
// Normalize input: trim and lowercase the wallet address
const normalizedWalletAddress = walletAddress.trim().toLowerCase();


// Check if user already exists
const existingUser = await prisma.apiUser.findUnique({
where: { walletAddress: walletAddress.toLowerCase() },
where: { walletAddress: normalizedWalletAddress },
});

if (existingUser) {
Expand All @@ -63,9 +71,10 @@ export default async function registerRoute(fastify: FastifyInstance) {

try {
// Create new user

const newUser = await prisma.apiUser.create({
data: {
walletAddress: walletAddress.toLowerCase(),
walletAddress: normalizedWalletAddress,
},
});

Expand All @@ -76,10 +85,12 @@ export default async function registerRoute(fastify: FastifyInstance) {
});
} catch (error) {
// This will be caught by asyncHandler

// Handle race condition where user was created between our check and create
// This can happen if two requests for the same wallet address are processed simultaneously.
if ((error as any)?.code === "P2002") {
// Handle race condition where user was created between our check and create
const existingUser = await prisma.apiUser.findUnique({
where: { walletAddress: walletAddress.toLowerCase() },
where: { walletAddress: normalizedWalletAddress },
});

if (existingUser) {
Expand Down